Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused @df.setter #440

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Remove unused @df.setter #440

merged 2 commits into from
Feb 1, 2022

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Feb 1, 2022

Change Summary

The @df.setter method isn't used/allowed by Pydantic. This PR removes it.

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-78-2517183ee52f> in <module>
----> 1 cat.df = None

/glade/work/abanihi/opt/miniconda/envs/ecgtools-dev/lib/python3.9/site-packages/pydantic/main.cpython-39-x86_64-linux-gnu.so in pydantic.main.BaseModel.__setattr__()

ValueError: "ESMCatalogModel" object has no field "df"

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@andersy005 andersy005 changed the title Make _df a private attribute Remove unused @df.setter Feb 1, 2022
@andersy005 andersy005 merged commit 8d2d302 into main Feb 1, 2022
@andersy005 andersy005 deleted the update-cat-model branch February 1, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant