Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace applymap with map #639

Merged
merged 3 commits into from Nov 9, 2023
Merged

Conversation

dougiesquire
Copy link
Contributor

@dougiesquire dougiesquire commented Nov 2, 2023

Change Summary

Very small change to replace deprecated pandas df.applymap method with df.map. The map method was added in pandas 2.1.0, so this min version is added to the requirements and ci environments. I guess this min version should also be added to the conda-forge feedstock recipe, but I'll leave that to one of the maintainers.

Related issue number

Closes #629

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks @dougiesquire

@mgrover1 mgrover1 merged commit aaad72e into intake:main Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future warning for applymap deprecation
3 participants