Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow simplecache #14

Merged
merged 18 commits into from Feb 16, 2021
Merged

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Feb 12, 2021

  1. I allow both netcdf and opendap (default) as drivers.
  2. simplecache:: in filestring allowed

also includes: testing on smaller nc files, but still not self hosted thredds.

Should I generalize for other actions:: like zip::/*.nc or filecache::, so far only simplecache:: but I dont see the need for others in thredds

@aaronspring aaronspring marked this pull request as ready for review February 12, 2021 21:23
@andersy005
Copy link
Member

@aaronspring, the Python 3.7 CI is failing due to the fact that conda/mamba are installing the pypy implementation of Python instead of the cpython implementation. When you get a chance add this line to dependencies section in the environment files in ci/ directory

- python=*=*cp*

tests/test_source.py Outdated Show resolved Hide resolved
@aaronspring
Copy link
Collaborator Author

We should move on with some documentation of this package next.

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aaronspring!

Should I generalize for other actions:: like zip::/*.nc or filecache::, so far only simplecache:: but I dont see the need for others in thredds

I'm in favor of revisiting/generalizing this in a separate PR.

@andersy005
Copy link
Member

We should move on with some documentation of this package next.

👍🏽 Definitely

@andersy005 andersy005 merged commit 4abf670 into intake:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants