add driver and simplecache example #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Co-authored-by: Aaron Spring <aaronspring@users.noreply.github.com>
aaronspring
commented
Feb 17, 2021
|
I should have directly commited into #19. instead this PR want to commit into NCAR:add-docs I resolved conflicts, https://intake-thredds--20.org.readthedocs.build/en/20/tutorial.html#id1 looks good. But I am unsure how to merge this PR into master. or should I just open a new PR? |
|
I changed the base branch to
Can you try rebasing against the upstream/main to address the conflicts? Sorry for the extra work :) |
andersy005
reviewed
Feb 17, 2021
Co-authored-by: Anderson Banihirwe <axbanihirwe@ualr.edu>
andersy005
reviewed
Feb 17, 2021
Co-authored-by: Anderson Banihirwe <axbanihirwe@ualr.edu>
|
This is also an issue in the main branch...
|
|
@aaronspring, yeah... I saw that. It's weird that the cell fails but everything else after it still works. Also, I notice some weird dask dependency issues in #19. Let's merge this as is for now and investigate the issue in a separate PR if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.