New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FutureWarning in intake_xarray.netcdf.NetCDFSource() #55

Merged

jsignell merged 1 commit into intake:master from christine-e-smit:warning

Sep 24, 2019

Contributor

christine-e-smit commented Sep 24, 2019

This change removes the future warning:

FutureWarning: In xarray version 0.14 the default behaviour of `open_mfdataset`
will change. To retain the existing behavior, pass
combine='nested'. To use future default behavior, pass
combine='by_coords'. See
http://xarray.pydata.org/en/stable/combining.html#combining-multi

in the intake_xarray/tests/test_intake_xarray.py unit test. Issue is documented in #54.


          Fix FutureWarning in intake_xarray.netcdf.NetCDFSource()

e6db908

Member

jsignell commented Sep 24, 2019

Looks good to me! Thanks for the contribution!

jsignell merged commit 597e907 into intake:master

jsignell mentioned this pull request

FutureWarning from intake after using intake_xarray.netcdf.NetCDFSource() #54

Closed

christine-e-smit deleted the warning branch

September 24, 2019 20:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment