Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of infer_storage_options #388

Closed
wants to merge 1 commit into from
Closed

Fix import of infer_storage_options #388

wants to merge 1 commit into from

Conversation

rafa-guedes
Copy link
Contributor

@rafa-guedes rafa-guedes commented Jul 24, 2019

intake is trying to import infer_storage_options from dask.bytes.utils but it sits in dask.bytes.core in master version of dask. This should fix:

In [1]: import intake                                                                                                                   
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-6ae586f3fa7a> in <module>
----> 1 import intake, intake_xarray

~/Envs/py3/lib/python3.7/site-packages/intake/__init__.py in <module>
     14 del get_versions
     15 from . import source
---> 16 from .source.base import Schema, DataSource
     17 from .catalog.base import Catalog, RemoteCatalog
     18 from .catalog import local

~/Envs/py3/lib/python3.7/site-packages/intake/source/base.py in <module>
      9 '''
     10 
---> 11 from .cache import make_caches
     12 from ..utils import make_path_posix, DictSerialiseMixin
     13 import sys

~/Envs/py3/lib/python3.7/site-packages/intake/source/cache.py in <module>
     18 import warnings
     19 
---> 20 from dask.bytes.utils import infer_storage_options
     21 from intake.config import conf
     22 from intake.utils import make_path_posix

ImportError: cannot import name 'infer_storage_options' from 'dask.bytes.utils' (/source/dask/dask/bytes/utils.py)

@martindurant
Copy link
Member

I believe this is fixed in #381 - can you check?

@rafa-guedes
Copy link
Contributor Author

Yep this is fixed there.. I came up with a few other missing paths though, will maybe open a pull request on your fork.

@martindurant
Copy link
Member

Please do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants