Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

馃敟 Terminate MSS with extreme prejudice #1162

Merged
merged 1 commit into from Nov 21, 2019

Conversation

grdryn
Copy link
Member

@grdryn grdryn commented Nov 20, 2019

JIRA: https://issues.jboss.org/browse/AEROGEAR-10077

  • Don't install MSS any longer
  • Remove MSS from existing clusters

Not removing the CRDs as part of the upgrade, since if people have created CRs for those, then I'd imagine that could break upgrade on that cluster.

Verification Steps

As the verifier of the PR the following process should be done:

Installation Verification

  • Ensure the author of the PR has attached a log of the installation run from his branch to the jira or pr and check that it exited as expected.
  • Verify the fresh installation is correct on cluster provided by PR author

Installation log: https://gist.github.com/grdryn/5e6d60287e5f902a1ae7e6265734230f
RHPDS cluster GUID: freshmss-4732

There should be no mobile-security-service namespace

Upgrade Verification

  • After installation verification, notify the PR author to begin an upgrade on their cluster
  • Ensure the developer of the PR has attached a log of the upgrade run from his branch to the jira or pr and check that it exited as expected.
  • If possible, look at the tasks that ran and see they match the PR
  • Verify the upgrade is correct on cluster provided by PR author

Upgrade log: https://gist.github.com/grdryn/401e6e610c099acc7c0b97fb662cd133
RHPDS cluster GUID: upgrdryn-af79

Upgrade should have remove mobile-security-service.

Is an upgrade task required and are there additional steps needed to test this?

  • Yes
  • No

Why is Yes/No multiple choice? 馃榾

  • Tested Installation
  • Tested Uninstallation
  • Tested or Created follow on for Upgrade

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 20, 2019
@grdryn
Copy link
Member Author

grdryn commented Nov 20, 2019

/assign @maleck13

/cc @ziccardi @wei-lee

playbooks/upgrade.yml Outdated Show resolved Hide resolved
@grdryn
Copy link
Member Author

grdryn commented Nov 20, 2019

Running an installation & an upgrade on RHPDS clusters now. I forgot to log the fresh install one to a file, so I might not be able to add all of the logs from it (assuming it succeeds).

@grdryn
Copy link
Member Author

grdryn commented Nov 20, 2019

Both install & upgrade worked successfully (logs included in description).

@mikenairn @maleck13 it probably makes more sense for one of you from RHMI to review this than someone from my team, wdyt?

@mikenairn
Copy link
Member

/lgtm

It all looks fine to me, but i haven't tested it, are we happy that it's been tested enough?

We will also need a PR to remove the DeLorean jobs for mss and mss-operator https://github.com/integr8ly/ci-cd/tree/master/jobs/delorean

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@grdryn
Copy link
Member Author

grdryn commented Nov 21, 2019

We will also need a PR to remove the DeLorean jobs for mss and mss-operator https://github.com/integr8ly/ci-cd/tree/master/jobs/delorean

I've created the following PR there just now: integr8ly/ci-cd#356

@mikenairn
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4268cd5 into integr8ly:master Nov 21, 2019
@grdryn grdryn deleted the AEROGEAR-10077 branch November 21, 2019 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants