This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
replace MDC with UPS #1167
Merged
openshift-merge-robot
merged 2 commits into
integr8ly:master
from
secondsun:replace_mdc_with_ups
Nov 27, 2019
Merged
replace MDC with UPS #1167
openshift-merge-robot
merged 2 commits into
integr8ly:master
from
secondsun:replace_mdc_with_ups
Nov 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Nov 22, 2019
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Nov 26, 2019
secondsun
force-pushed
the
replace_mdc_with_ups
branch
from
November 26, 2019 18:41
486cfe7
to
8889cd1
Compare
logs
|
/assign @wei-lee |
wei-lee
reviewed
Nov 27, 2019
wei-lee
reviewed
Nov 27, 2019
wei-lee
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
secondsun
force-pushed
the
replace_mdc_with_ups
branch
from
November 27, 2019 15:02
7c759d1
to
112e51b
Compare
secondsun
force-pushed
the
replace_mdc_with_ups
branch
from
November 27, 2019 15:21
112e51b
to
33a6fb6
Compare
@wei-lee Ok I'm ready for you to rereview. I've rebased and everything |
secondsun
force-pushed
the
replace_mdc_with_ups
branch
from
November 27, 2019 16:23
33a6fb6
to
80d62e0
Compare
wei-lee
approved these changes
Nov 27, 2019
/approve |
/assign @jessesarn |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jessesarn, wei-lee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Nov 27, 2019
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces MDC with UPS in the list of services that SolX displays.
Verification Steps :
Cluster link :
here : https://tutorial-web-app-webapp.apps.atlanta-70af.open.redhat.com