Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resync routes 3Scale #1145

Merged
merged 1 commit into from Sep 16, 2020
Merged

resync routes 3Scale #1145

merged 1 commit into from Sep 16, 2020

Conversation

briangallagher
Copy link
Contributor

@briangallagher briangallagher commented Aug 25, 2020 •
edited

Description

Previously there was a need to resync routes after a 3Scale restoration by running the following command in a 3Scale pod:
bundle exec rake zync:resync:domains

This is now built into the 3Scale product reconcile.

Verification

  • Install RHMI
  • Then, delete the redhat-rhmi-3scale namespace and ensure it restores (verify product)
  • Then, delete the redhat-rhmi-3scale-operator namespace and ensure the operator and product work as expected.

@coveralls
Copy link

coveralls commented Aug 25, 2020 •
edited

Coverage Status

Coverage decreased (-0.2%) to 59.886% when pulling 3fb4767 on briangallagher:7084-resync-routes-3scale into e2cc49f on integr8ly:master.

@briangallagher
Copy link
Contributor Author

/retest

1 similar comment
@briangallagher
Copy link
Contributor Author

/retest

@briangallagher briangallagher force-pushed the 7084-resync-routes-3scale branch 2 times, most recently from af2568d to e97e0ca Compare August 27, 2020 12:46
@briangallagher briangallagher changed the title [WIP] resync routes 3Scale resync routes 3Scale Aug 27, 2020
@briangallagher
Copy link
Contributor Author

/retest

@briangallagher briangallagher force-pushed the 7084-resync-routes-3scale branch 2 times, most recently from e9d7c21 to d713483 Compare September 9, 2020 12:47
@briangallagher
Copy link
Contributor Author

@Boomatang Can you retest this please. Should be more stable now

@Boomatang
Copy link
Contributor

I have tried this again.

  • Deleted 3scale namespace
  • Deleted 3scale-operator namespace
  • Deleted 3scale & 3scale-operator namespace
    Every time it seemed to come back working. After doing the multiply deletes I ran the functional test which passed as expected. Failing test where around aws which is understandable on a non-byoc.

\lgtm

@Boomatang
Copy link
Contributor

/lgtm

@matskiv
Copy link
Member

matskiv commented Sep 16, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matskiv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@briangallagher
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 8a70aaa into integr8ly:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Boomatang Boomatang

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@briangallagher @coveralls @Boomatang @matskiv @openshift-ci-robot @openshift-merge-robot