Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-3696 - Create Initial Fleet wide SRE Dashboard querying observ… #2616

Closed
wants to merge 1 commit into from

Conversation

valerymo
Copy link
Contributor

@valerymo valerymo commented Apr 20, 2022

Issue link

https://issues.redhat.com/browse/MGDAPI-3696
Merge to master, after MGDAPI-3695 task (metrics that used in MGDAPI-3696)

What

Create Initial Fleet wide SRE Dashboard querying Observatorium
Grafana dashboard displaying data that is captured in this JIRA
The Grafana used will be managed by AppSRE and will query Observatorium.
Presentation doc for reference: https://docs.google.com/document/d/1FG1wzFvjPccRfn_ICEj66NGQMkxRF3-dKT-V7KJoNcE/edit

Verification steps / notes

  1. "Rhoam Fleet Wide View" Dashboard is optional. To have it - Environment variable "FLEET_VIEW" need to be defined.
  2. Two cases need to be checked (with and without Fleet vew Dashboard
    2.1. without Fleet view Dashboard. Grafana should work as usual, No Fleet vew Dashboard present
    2.2 with Fleet view Dashboard.
  3. To Review "Rhoam Fleet Wide View" Dashboard - check that all Graphs of the dashboard are working. Simulate alerts.
    For reference please see the doc
    Notes. This new dashboard will work with Observatorium in future. It designed to display the data from several clusters, managed by Observatorium. Currently it display data from one cluster.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign briangallagher after the PR has been reviewed.
You can assign the PR to them by writing /assign @briangallagher in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (700a983) 69.01% compared to head (229ff11) 69.00%.
Report is 1358 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
- Coverage   69.01%   69.00%   -0.01%     
==========================================
  Files         147      147              
  Lines       34572    34577       +5     
==========================================
  Hits        23860    23860              
- Misses       9699     9704       +5     
  Partials     1013     1013              
Files Coverage Δ
pkg/products/monitoringcommon/dashboardHelper.go 94.59% <0.00%> (-5.41%) ⬇️
pkg/config/observability.go 19.78% <0.00%> (-0.68%) ⬇️

@valerymo valerymo force-pushed the valery_MGDAPI-3696-1 branch 2 times, most recently from 90fae91 to 973eec6 Compare April 24, 2022 12:36
@valerymo valerymo changed the title [WIP] MGDAPI-3696 - Create Initial Fleet wide SRE Dashboard querying observ… MGDAPI-3696 - Create Initial Fleet wide SRE Dashboard querying observ… Apr 24, 2022
@valerymo valerymo force-pushed the valery_MGDAPI-3696-1 branch 2 times, most recently from 85a7ed1 to dc81936 Compare April 24, 2022 12:50
@valerymo valerymo changed the title MGDAPI-3696 - Create Initial Fleet wide SRE Dashboard querying observ… [WIP]MGDAPI-3696 - Create Initial Fleet wide SRE Dashboard querying observ… Apr 25, 2022
@valerymo valerymo force-pushed the valery_MGDAPI-3696-1 branch 3 times, most recently from 6e476df to 91ed688 Compare April 28, 2022 14:24
@valerymo valerymo changed the title [WIP]MGDAPI-3696 - Create Initial Fleet wide SRE Dashboard querying observ… MGDAPI-3696 - Create Initial Fleet wide SRE Dashboard querying observ… Apr 28, 2022
@valerymo valerymo force-pushed the valery_MGDAPI-3696-1 branch 5 times, most recently from 36d7801 to f0b00e7 Compare May 15, 2022 17:06
@MStokluska
Copy link
Member

@valerymo can this be closed or does it need to be done?

@MStokluska MStokluska closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants