Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-4488 : Adding Telemetry Rules #2936

Merged
merged 1 commit into from Oct 11, 2022

Conversation

Boomatang
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/MGDAPI-4488

What

Add reformatted version of rhoam metrics to the cluster Prometheus.

This work is need to allow openshift/cluster-monitoring-operator#1771 to work correctly

Verification steps

  • Build and install the operator via OLM
  • Check that a new prometheus has being created in the openshift-monitoring namespace called rhoam-telemetry
  • From the cluster metrics run the following queries
    • status:upgrading:version:rhoam_state:max
    • status:upgrading:version:rhoam_state:max
    • state:rhoams_warning_alerts:max
  • Expected: there should be entries for all mertics

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #2936 (96e8f64) into master (2e81774) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2936      +/-   ##
==========================================
- Coverage   71.77%   71.75%   -0.03%     
==========================================
  Files         119      120       +1     
  Lines       32833    32852      +19     
==========================================
+ Hits        23565    23572       +7     
- Misses       8225     8234       +9     
- Partials     1043     1046       +3     
Impacted Files Coverage Δ
pkg/products/rhssocommon/reconciler.go 66.39% <0.00%> (-0.41%) ⬇️
pkg/products/rhssouser/reconciler.go 46.87% <0.00%> (-0.12%) ⬇️
pkg/products/marin3r/reconciler.go 4.98% <0.00%> (-0.07%) ⬇️
pkg/products/threescale/reconciler.go 61.49% <0.00%> (-0.07%) ⬇️
pkg/resources/waitForResources.go 100.00% <0.00%> (ø)

Copy link
Contributor

@cecobask cecobask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the verification instructions and confirm that everything works as expected:

image

/lgtm

@laurafitzgerald
Copy link
Contributor

/override ci/prow/coverage

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: ci/prow/coverage

In response to this:

/override ci/prow/coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@laurafitzgerald
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cecobask, laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2022
@laurafitzgerald
Copy link
Contributor

/override ci/prow/coverage

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: ci/prow/coverage

In response to this:

/override ci/prow/coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@laurafitzgerald
Copy link
Contributor

/override codecov/project

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit e1872a9 into integr8ly:master Oct 11, 2022
@cecobask cecobask deleted the MGDAPI-4488 branch October 24, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants