Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obo mkdocs #3293

Merged
Merged

Conversation

Boomatang
Copy link
Contributor

Issue link

https://issues.redhat.com/browse/MGDAPI-5882

What

Update mkdocs configuration for obo

Verification steps

  • check out this branch locally
  • run make mkdocs/serve
  • view the page on localhost:8000
  • Confirm obo docs are included
    image

@Boomatang Boomatang changed the base branch from master to mgdapi-5727-obo June 28, 2023 15:48
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #3293 (374ff78) into mgdapi-5727-obo (a532220) will decrease coverage by 0.86%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           mgdapi-5727-obo    #3293      +/-   ##
===================================================
- Coverage            73.20%   72.34%   -0.86%     
===================================================
  Files                  104      104              
  Lines                29516    30317     +801     
===================================================
+ Hits                 21606    21932     +326     
- Misses                7132     7593     +461     
- Partials               778      792      +14     

see 11 files with indirect coverage changes

@KevFan
Copy link
Contributor

KevFan commented Jun 29, 2023

  • Verified obo docs are included
    image

/lgtm

@austincunningham
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austincunningham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@austincunningham
Copy link
Member

/override codecov/project

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

@austincunningham: Overrode contexts on behalf of austincunningham: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 59e8caf into integr8ly:mgdapi-5727-obo Jun 29, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants