Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-5901 - feat: addon instance uninstallation flow #3303

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

KevFan
Copy link
Contributor

@KevFan KevFan commented Jul 6, 2023

Issue link

https://issues.redhat.com/browse/MGDAPI-5901

What

Verification steps

  • Checkout this branch
  • Install RHOAM
export LOCAL=false
make cluster/prepare/local
make code/run
  • Verify installation completes successfully
  • Mark addon instance spec for addon deletion
oc patch addoninstance addon-instance -p $'spec:\n markedForDeletion: true' --type merge -n redhat-rhoam-operator
  • Verify RHMI CR is marked for deletion
  • Verify uninstallation completed successfully
  • Verify a new status condition is added
watch "oc get addoninstance addon-instance -n redhat-rhoam-operator -o json | jq '.status'"
  • The following should be added after a successfull uninstall to signal that the addon can be removed in ocm
    {
      "lastTransitionTime": "2023-07-06T13:07:43Z",
      "message": "Addon ready to be deleted",
      "observedGeneration": 2,
      "reason": "AddonReadyToBeDeleted",
      "status": "True",
      "type": "addons.managed.openshift.io/ReadyToBeDeleted"
    }

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3303 (1440432) into master (7d22568) will decrease coverage by 0.65%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   72.95%   72.30%   -0.65%     
==========================================
  Files         107      107              
  Lines       29864    30194     +330     
==========================================
+ Hits        21786    21832      +46     
- Misses       7284     7566     +282     
- Partials      794      796       +2     
Impacted Files Coverage Δ
apis/v1alpha1/rhmi_conditions.go 100.00% <100.00%> (ø)
controllers/status/status_controller.go 77.50% <100.00%> (+0.87%) ⬆️

... and 1 file with indirect coverage changes

@KevFan KevFan force-pushed the MGDAPI-5901 branch 3 times, most recently from acd3981 to 76907bf Compare July 6, 2023 15:54
@KevFan KevFan changed the title [WIP] MGDAPI-5901 - feat: addon instance uninstallation flow MGDAPI-5901 - feat: addon instance uninstallation flow Jul 7, 2023
@Patryk-Stefanski
Copy link
Contributor

The verification steps were successful and the code looks good.
/lgtm

@MStokluska
Copy link
Member

/approve

@austincunningham
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austincunningham, MStokluska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MStokluska,austincunningham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KevFan
Copy link
Contributor Author

KevFan commented Jul 12, 2023

/override codecov/project

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

@KevFan: Overrode contexts on behalf of KevFan: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1c08730 into integr8ly:master Jul 12, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants