Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-5884 - fix e2e tests failing on OBO feature branch #3316

Merged

Conversation

kramaranya
Copy link
Contributor

@kramaranya kramaranya commented Jul 13, 2023

Issue link

MGDAPI-5884

What

Fix all e2e tests failing on OBO feature branch:

  • C03 - Verify that alerting mechanism works
  • Verify prometheus metrics scrapped
  • Validate resource requirements are set - MR

Verification steps

  • Provision an OSD cluster
  • Checkout this branch
  • Install RHOAM
  • Run the following commands:
INSTALLATION_TYPE=managed-api TEST="C03" make test/e2e/single
INSTALLATION_TYPE=managed-api TEST="Verify prometheus metrics scrapped" make test/e2e/single
INSTALLATION_TYPE=managed-api TEST="Validate resource requirements are set" make test/e2e/single

For the last one you need to include MR from MTBR if it's not merged yet.

  • Validate that all tests are passing

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #3316 (1a81267) into mgdapi-5727-obo (8920a4d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           mgdapi-5727-obo    #3316   +/-   ##
================================================
  Coverage            47.64%   47.64%           
================================================
  Files                   95       95           
  Lines                14420    14420           
================================================
  Hits                  6870     6870           
  Misses                6783     6783           
  Partials               767      767           

@carlkyrillos
Copy link
Contributor

Verified that all three tests pass with the latest changes
/lgtm

@austincunningham
Copy link
Member

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austincunningham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit daa0715 into integr8ly:mgdapi-5727-obo Jul 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants