Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-6227 Bump images of RHSSO and Grafana & Grafana-ose-oauth-proxy #3442

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

valerymo
Copy link
Contributor

@valerymo valerymo commented Feb 21, 2024

Issue link

Jira: https://issues.redhat.com/browse/MGDAPI-6227

Recreated from #3435 (based on updated master)
Please see Review comments, lgtm and approval in old PR

What

For all Task details please see Jira.

What was done in PR

  • Images updated for RHSSO and Grafana & Grafana-ose-oauth-proxy
  • Envoy image - no need update, we are using latest
  • Dependabot PRs for test-cases - decided to close (I will write the list of these PRs into Task comments)

Verification steps

  • Sanity test of RHOAM
  • Open Grafana UI and see that Ratelimit Dashboard is working as expected

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8bd31b4) 47.92% compared to head (33b0a60) 48.36%.
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3442      +/-   ##
==========================================
+ Coverage   47.92%   48.36%   +0.44%     
==========================================
  Files          97       97              
  Lines       13690    13794     +104     
==========================================
+ Hits         6561     6672     +111     
+ Misses       6416     6407       -9     
- Partials      713      715       +2     
Files Coverage Δ
pkg/products/rhsso/reconciler.go 44.44% <100.00%> (ø)
pkg/products/rhssouser/reconciler.go 47.66% <100.00%> (ø)
pkg/products/grafana/reconciler.go 2.68% <0.00%> (ø)

... and 1 file with indirect coverage changes

@valerymo
Copy link
Contributor Author

/test multitenant-rhoam-e2e

@carlkyrillos
Copy link
Contributor

Re-reviewed changed files and verified that the Rate Limiting dashboard is working as expected.
/lgtm

@valerymo
Copy link
Contributor Author

/test rhoam-e2e
/test multitenant-rhoam-e2e

@valerymo
Copy link
Contributor Author

/test multitenant-rhoam-e2e

@MStokluska
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MStokluska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 99d1cdb into integr8ly:master Feb 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants