INTLY-7398 allow dedicated admins modify 3scale routes #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
briangallagher
force-pushed
the
INTLY-7398-new-role
branch
from
9388ea8
to
2cc22f4
Compare
|
/retest |
1 similar comment
|
/retest |
|
This test failure is a bit concerning: |
|
@matskiv Thanks, looking into this now |
briangallagher
changed the title
|
E2E test failure is tracked here btw: https://issues.redhat.com/browse/INTLY-7831 |
|
/retest |
briangallagher
force-pushed
the
INTLY-7398-new-role
branch
from
1b32713
to
4a4c690
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matskiv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e |
2 similar comments
|
/test e2e |
|
/test e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new Role that allows the dedicated admin group edit routes in the rhmi 3scale namespace
Type of change
Verify
Verification1
Patch the route as dedicated admin and verify success:
Patch the route as rhmi developer and verify permission denied error:
oc patch route backend -p '{"metadata":{"labels":{"test":"version1"}}}' -n redhat-rhmi-3scaleVerification2
Wait a period of time to verify that the rhmi reconciler does not revert the patch change
Verification3
Check that zync:domains:resync command won't case the changes to be reverted (run the following command within the system-app pod - bundle exec rake zync:resync:domains ).