Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

chore:replace mdc with ups #51

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

secondsun
Copy link
Contributor

Motivation

This replaces MDC with UPS a a managed mobile service

What

MDC services are removed, UPS code is added

Why

MDC is being removed from mobile, and UPS is being promoted.

Verification Steps

  1. Deploy a i8ly cluster
  2. Use make to build a container image with this PR and configure i8ly to use that image (using the code paths of your choice)
  3. Wait... It takjes a few minutes for the msb to recreate the necessary clusterserviceclasses and friends
  4. run oc get clusterserviceclasses --all-namespaces (assuming you are logged into the cluster you are testing
  5. Verify that a clusterserviceclass unifiedpush-service-id has been created

Checklist:

  • [ x ] Code has been tested locally by PR requester
  • Changes have been successfully verified by another team member

Progress

  • Finished task

@secondsun
Copy link
Contributor Author

@maleck13 github suggested you as a reviewer feel free to point me in the right direction

@maleck13
Copy link
Contributor

@secondsun the code changes look reasonable to me. @philbrookes or @JameelB are probably better placed to approve though as they did the most work on this component

@secondsun
Copy link
Contributor Author

@maleck13 Thanks! I just tagged @philbrookes as a reviewer

@secondsun
Copy link
Contributor Author

@philbrookes Can you give this a look/+1?

@philbrookes
Copy link
Member

this looks good to me too.

@secondsun secondsun merged commit a26935b into integr8ly:master Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants