Pass user-generated Stripe exceptions through #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that when StripeError is generated during the subscribed block, the exception is passed through to layers past StripeEvent rather than caught and returning a 401. Mostly useful during development to let developers see their exceptions. Re issue integrallis#23
| @@ -19,6 +19,15 @@ def event_post(params) | |||
| expect(response.code).to eq '401' | |||
| end | |||
|
|
|||
| it "ensures user-generated Stripe exceptions pass through" do | |||
| StripeEvent.setup do | |||
There was a problem hiding this comment.
You can use StripeEvent.subscribe('charge.succeeded') { |event| raise Stripe::StripeError } to be slightly more concise in tests.
|
Looks great. I'll figure out why the Rubinius tests are failing and fix it. Thank you! |
invisiblefunnel
added a commit
that referenced
this pull request
Dec 9, 2013
Pass user-generated Stripe exceptions through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that when StripeError is generated during the subscribed
block, the exception is passed through to layers past StripeEvent
rather than caught and returning a 401. Mostly useful during development
to let developers see their exceptions.
Re issue #23