Set sonar.delphi.installationPath when initializing SonarDelphi #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cirras
requested changes
Mar 20, 2024
...t-server/src/main/java/au/com/integradev/delphilint/analysis/EngineStartupConfiguration.java
Outdated
Show resolved
Hide resolved
fourls
force-pushed
the
delphi-12-compat
branch
3 times, most recently
from
e752f00
to
daa76bf
Compare
Cirras
requested changes
Mar 20, 2024
fourls
force-pushed
the
delphi-12-compat
branch
from
daa76bf
to
361273e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10 by using the correct setting name for the SonarDelphi property containing Delphi installation.
DelphiLint currently incorrectly passes the Delphi installation through to SonarDelphi using the
sonar.delphi.bds.pathsetting, which was replaced bysonar.delphi.installationPathin SonarDelphi 1.0.0. As a result, SonarDelphi uses the default Delphi 11 installation path in all cases, which causes errors when Delphi 11 is not installed.