Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for clearing file issues in the Delphi IDE #24

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

fourls
Copy link
Collaborator

@fourls fourls commented Apr 16, 2024

This PR adds a new "Clear Active File" menu option to the Delphi IDE, which (as the name suggests) clears all issues from the active file.

This has required a number of refactors, particularly around ensuring that issue objects can be relied upon to persist after their analysis has been deleted.

Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you may have accidentally flipped DelphiLint.Plugin to utf-8 (without bom) which will be interpreted as ansi by the compiler.
image

@Cirras
Copy link
Collaborator

Cirras commented Apr 17, 2024

Same thing in DelphiLint.ToolFrame.
image

@Cirras
Copy link
Collaborator

Cirras commented Apr 17, 2024

Looks like both files were flipped to utf-8 in c215b2a and then flipped back to ansi in 370fa94.

@fourls
Copy link
Collaborator Author

fourls commented Apr 17, 2024

Huh... how weird. I'll fix that up.

Copy link
Collaborator

@Cirras Cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fourls fourls merged commit affbd02 into master Apr 18, 2024
1 check passed
@fourls fourls deleted the clear-issues branch April 18, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants