-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support standalone mode rule configuration #37
Conversation
Implemented compatibility with the new features in the VS Code companion - while you can't customise the rules from within VSCode, it will honour the disabled rules configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great bit of work here, love the new settings panel.
A few minor comments, but overall code looks good. I'll be doing some additional user testing as well before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR adds a new user-level configuration setting to configure which rules are applied in standalone mode:
By default, DelphiLint is configured to use SonarDelphi's default ruleset (the Sonar way profile), preserving existing behaviour. Users can opt-in to configure their own ruleset, at which point they can enable or disable which rules they like. Under the hood, only disabled rules are stored, meaning that any new rules that appear as a result of a SonarDelphi upgrade will be automatically enabled.
As tends to happen with these sorts of paradigm-shift changes, this PR also includes a few collateral improvements:
SonarHostTokens
settings item is no longer capped at 2048 charactersFixes #16