-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfurled previews are too big #564
Comments
The Desktop team is having issues with previews taking up too much real-estate causing our conversations to be lost in the mix. Something that would solve this problem for us is to not automatically expand a notification. Instead, allow the expansion of a notification to be an opt-in by the person viewing it. I've sent @bkeepers a DM with a GIF illustrating how much screen is taken up by these. |
Thanks for the feedback!
Unfortunately, Slack doesn't give us this level of control over the message formatting. They fold content based on number of characters and there's not a way to mark content as collapsable. Everyone in the channel is given the same view of the messages. We've had a few teams report concerns with the size of the message, and it's usually when there's an issue template or something that includes a lot of lines but few characters (since Slack folds solely based on character count). The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications. Would that solve your problem here? |
Yes, I think that's a fine solution given the constraints Slack places on us. |
JIRA integration similarly offers a configuration that gives you a condensed version of previews. |
Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed. |
Yes still a desired feature. |
This is an important fix, it's basically stopping our org from adopting this integration because it basically spams the entire channel. |
This is still an issue in the #desktop channel as well. |
I would also like to be able to configure certain event types to always be condensed. For example, one pull request in my channel right now takes up 6 lines:
That's way more than the old integration and also way too much detail for that. I'd much rather:
|
Also if I look at the screenshot OP posted, then he's having exactly the same issue I am, except that the PR I'm looking at doesn't have a description in it. I think there's a bug here, so I've opened a new issue: #668. |
I would also like to bump this feature as something that would be perfect to handle with a small user configuration option. The option be either be at the Channel level or overall App level (maybe Channel settings would override App). As mentioned earlier, the Jira <-> slack integration allows you to choose between a Message Style of what they call |
Experiencing the same problem with noise from verbose previews. A very good description of the issue can be found here: #595. In my ideal world, a github PR/issue preview would only have a few of lines mentioning: repo, PR title, author, status (open/closed), and labels. |
Issues are too large, it's terribly distracting. We can't use the GitHub integration at all because of this. |
I ended up uninstalling this integration and going back to the "Legacy" Github Notifications app for my team. It's a pity because controlling subscriptions from slack with commands is a great idea, but the core functionality is just not going to work if you can't control messages' appearance. |
Months go by and this continues to be terrible. |
@skyvondave That's not related to the GitHub integration… That's just a regular link unfurl. For the Google Play store. |
A condensed version of the output would be perfect. Just omit certain fields that get pushed to slack. |
These messages are way too long, especially for those of us who use checklists and PR templates. |
+1 -- This is still an issue for our team, would be great if there was more flexibility in how much is shown |
+1 to this. We enabled this recently and now everyone is hating it for too much information, if this is not fixed soon, we might just move away from this integration |
Please fix faster. It's been a year. |
when multiple github PRs are linked it shows a lovely condensed version of the PR title and just chills. Why is the bot so extra when it's just one link? |
Slack is unfurling too much text and too large of a picture. It adds up to taking up a crazy amount of space and overwhelming the hand-typed message above it. |
@bkeepers - I think the condensed view would be a great feature. Is this work captured anywhere? Should I open a new issue asking for this feature or is this issue sufficient? |
👍 this is keeping me up at night thinking I've caused wasted pixels on my fellow team mates super wide screen monitors - I've lodged a support ticket too |
It's pretty obvious by now that no one cares. |
Good to know! 🤪 |
Sorry, it wasn't directed at you. It's just a joke that this has always been an issue and the poor behavior doesn't get addressed for 4+ years. |
I know... |
See also #1262 |
Sadly I'm going to have to turn this integration off because of channel spam. I really only wanted to have a 1-3 lines of text telling me when a PR was opened or merged. Combined with dependabot PRs it's too much. |
Hi @ashokirla Anyone going to assign and work on this request? |
Is this something that's still being considered? We're trying to clean up our channel noise and our Github PRs take up almost half of the screen whenever they are opened |
It doesn't look like this is going anywhere, which is a shame as it's clearly both strongly requested and technically possible. Please can this get some attention? |
For a 2-second PR, I don't get why this is still an issue 6 years later. You don't even need to truncate on a word boundary, just literally slice the string to 200 chars or whatever. Even plaintext with no formatting would be better than the status quo. Or even zero content, and just preview the title! |
I can't believe how long this issue has been open, but I'd like to chime in that the collective man-hours spent clicking the "x" to remove the preview due to these massive embeds is well worth the time to fix. |
Any advances about this? My team is considering dropping the integration all together as it just messes up the whole channel everyday |
Upvoting this. It would be nice to set preview length or drop the PR content in the preview |
Sometimes a teammate will open a PR, and the preview ends up being so big that it's almost as big as the Slack window itself (which is maximized)!
I feel like these previews could be condensed much more; there's so much text before the
Show more
link ends up being displayed, and its exacerbated by the PR having an image that gets previewed belowThe text was updated successfully, but these errors were encountered: