Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfurled previews are too big #564

Open
davidcelis opened this issue May 2, 2018 · 46 comments
Open

Unfurled previews are too big #564

davidcelis opened this issue May 2, 2018 · 46 comments

Comments

@davidcelis
Copy link

Sometimes a teammate will open a PR, and the preview ends up being so big that it's almost as big as the Slack window itself (which is maximized)!

toobig

I feel like these previews could be condensed much more; there's so much text before the Show more link ends up being displayed, and its exacerbated by the PR having an image that gets previewed below

@iAmWillShepherd
Copy link

The Desktop team is having issues with previews taking up too much real-estate causing our conversations to be lost in the mix. Something that would solve this problem for us is to not automatically expand a notification. Instead, allow the expansion of a notification to be an opt-in by the person viewing it. I've sent @bkeepers a DM with a GIF illustrating how much screen is taken up by these.

@bkeepers
Copy link
Contributor

Thanks for the feedback!

Instead, allow the expansion of a notification to be an opt-in by the person viewing it.

Unfortunately, Slack doesn't give us this level of control over the message formatting. They fold content based on number of characters and there's not a way to mark content as collapsable. Everyone in the channel is given the same view of the messages.

We've had a few teams report concerns with the size of the message, and it's usually when there's an issue template or something that includes a lot of lines but few characters (since Slack folds solely based on character count).

The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications.

Would that solve your problem here?

@iAmWillShepherd
Copy link

The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications.
Would that solve your problem here?

Yes, I think that's a fine solution given the constraints Slack places on us.

@jprestel-rue
Copy link

JIRA integration similarly offers a configuration that gives you a condensed version of previews.

@stale
Copy link

stale bot commented Aug 6, 2018

Is this still relevant? If so, just comment with any updates and we'll leave it open. Otherwise, if there is no further activity, it will be closed.

@stale stale bot added the wontfix label Aug 6, 2018
@jprestel-rue
Copy link

Yes still a desired feature.

@stale stale bot removed the wontfix label Aug 6, 2018
@pmyjavec
Copy link

This is an important fix, it's basically stopping our org from adopting this integration because it basically spams the entire channel.

@iAmWillShepherd
Copy link

This is still an issue in the #desktop channel as well.

@ziggythehamster
Copy link

I would also like to be able to configure certain event types to always be condensed. For example, one pull request in my channel right now takes up 6 lines:

Pull request opened by <username>
<icon> <username>
#<issue number> <issue title>
Labels
<label>
<repo> | <timestamp>

That's way more than the old integration and also way too much detail for that. I'd much rather:

<icon> <username>
Pull request opened: #<issue number> <issue title>
<repo> | <timestamp>

@ziggythehamster
Copy link

Also if I look at the screenshot OP posted, then he's having exactly the same issue I am, except that the PR I'm looking at doesn't have a description in it. I think there's a bug here, so I've opened a new issue: #668.

@mikelax
Copy link

mikelax commented Oct 26, 2018

I would also like to bump this feature as something that would be perfect to handle with a small user configuration option. The option be either be at the Channel level or overall App level (maybe Channel settings would override App).

As mentioned earlier, the Jira <-> slack integration allows you to choose between a Message Style of what they call Clean and Compact. Something similar here would be amazing, as currently Previews can be really large, especially if there is an image in the PR body.

@antonmorant
Copy link

Experiencing the same problem with noise from verbose previews. A very good description of the issue can be found here: #595.

In my ideal world, a github PR/issue preview would only have a few of lines mentioning: repo, PR title, author, status (open/closed), and labels.

@NathanSweet
Copy link

Issues are too large, it's terribly distracting. We can't use the GitHub integration at all because of this.

@antonmorant
Copy link

I ended up uninstalling this integration and going back to the "Legacy" Github Notifications app for my team. It's a pity because controlling subscriptions from slack with commands is a great idea, but the core functionality is just not going to work if you can't control messages' appearance.

@skyvondave
Copy link

The unfurling is just too much information most of the time:

image

Seriously, this is too much. Please chop it down or reduce the image size or let us configure how much unfurls.

@NathanSweet
Copy link

Months go by and this continues to be terrible.

@davidcelis
Copy link
Author

@skyvondave That's not related to the GitHub integration… That's just a regular link unfurl. For the Google Play store.

@bluetidepro
Copy link

A condensed version of the output would be perfect. Just omit certain fields that get pushed to slack.

@rgeraldporter
Copy link

These messages are way too long, especially for those of us who use checklists and PR templates.

@liangmicha
Copy link

+1 -- This is still an issue for our team, would be great if there was more flexibility in how much is shown

@mohammedzee1000
Copy link

+1 to this. We enabled this recently and now everyone is hating it for too much information, if this is not fixed soon, we might just move away from this integration

@repsejnworb
Copy link

Please fix faster. It's been a year.
We loved the integration, but nearly instantly turned it off due to the spam.

@jLouzado
Copy link

when multiple github PRs are linked it shows a lovely condensed version of the PR title and just chills. Why is the bot so extra when it's just one link?

@skyvondave
Copy link

@skyvondave That's not related to the GitHub integration… That's just a regular link unfurl. For the Google Play store.

Slack is unfurling too much text and too large of a picture. It adds up to taking up a crazy amount of space and overwhelming the hand-typed message above it.

@jpbufe3
Copy link

jpbufe3 commented Feb 14, 2020

Thanks for the feedback!

Instead, allow the expansion of a notification to be an opt-in by the person viewing it.

Unfortunately, Slack doesn't give us this level of control over the message formatting. They fold content based on number of characters and there's not a way to mark content as collapsable. Everyone in the channel is given the same view of the messages.

We've had a few teams report concerns with the size of the message, and it's usually when there's an issue template or something that includes a lot of lines but few characters (since Slack folds solely based on character count).

The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications.

Would that solve your problem here?

@bkeepers - I think the condensed view would be a great feature. Is this work captured anywhere? Should I open a new issue asking for this feature or is this issue sufficient?

@gareth
Copy link

gareth commented Apr 15, 2020

@jpbufe3 It looks like #162 is the request you're looking for?

@jpbufe3
Copy link

jpbufe3 commented Apr 15, 2020

@jpbufe3 It looks like #162 is the request you're looking for?

@gareth yes! Might be good to close this issue and mark it as a duplicate of #162?

@export-mike
Copy link

export-mike commented Mar 2, 2022

👍 this is keeping me up at night thinking I've caused wasted pixels on my fellow team mates super wide screen monitors - I've lodged a support ticket too

@FlipEverything
Copy link

image

So, you are telling me that this is the intended behavior for the GitHub slack integration? Why do you (or Slack) breaks the line after ~ 100 characters when I have a widescreen QHD display? Every notification could fit in a line... This wastes the pixels on my monitor...

@NathanSweet
Copy link

It's pretty obvious by now that no one cares.

@FlipEverything
Copy link

Good to know! 🤪

@NathanSweet
Copy link

Sorry, it wasn't directed at you. It's just a joke that this has always been an issue and the poor behavior doesn't get addressed for 4+ years.

@FlipEverything
Copy link

I know...

@jsoref
Copy link

jsoref commented Apr 1, 2022

See also #1262

@chris-wall-stint
Copy link

chris-wall-stint commented Apr 5, 2022

Frustratingly, there's a lovely compact GitHub preview when your message contains two GitHub links:
Screenshot 2022-04-05 at 08 55 21

But editing the message back to one link again causes the preview to refresh to the beast preview 🙄

[edit: oops just seen this has already been mentioned above]

@JayDouglass
Copy link

Sadly I'm going to have to turn this integration off because of channel spam. I really only wanted to have a 1-3 lines of text telling me when a PR was opened or merged. Combined with dependabot PRs it's too much.

@devurandom
Copy link

Frustratingly, there's a lovely compact GitHub preview when your message contains two GitHub links: Screenshot 2022-04-05 at 08 55 21

But editing the message back to one link again causes the preview to refresh to the beast preview roll_eyes

For me, too, having the compact preview (the one used when multiple GH links are posted) always would be preferrable. I would like to have a setting to always use that style.

@strativd
Copy link

+1 — also found a workaround!

Create all PRs as drafts 🎉

It's not an ideal workflow but it works ¯\_(ツ)_/¯


Screen Shot 2022-07-27 at 12 33 11 PM


@c-hardch
Copy link

Hi @ashokirla Anyone going to assign and work on this request?

@breen-laerdal
Copy link

Thanks for the feedback!

Instead, allow the expansion of a notification to be an opt-in by the person viewing it.

Unfortunately, Slack doesn't give us this level of control over the message formatting. They fold content based on number of characters and there's not a way to mark content as collapsable. Everyone in the channel is given the same view of the messages.

We've had a few teams report concerns with the size of the message, and it's usually when there's an issue template or something that includes a lot of lines but few characters (since Slack folds solely based on character count).

The option we've been considering is to add a per-channel setting for “condensed” messages that exclude things like the Issue/PR body from notifications.

Would that solve your problem here?

Is this something that's still being considered? We're trying to clean up our channel noise and our Github PRs take up almost half of the screen whenever they are opened

@EdwardSalkeld
Copy link

It doesn't look like this is going anywhere, which is a shame as it's clearly both strongly requested and technically possible. Please can this get some attention?

@wesbos
Copy link

wesbos commented Mar 15, 2024

anytime I share a few links I have to spend 20 seconds clicking the X so I don't totally destroy our group chat. They are way too big right now.

Like, I love Marco, but I don't ever need any photo embed to be this large

Screenshot 2024-03-15 at 11 39 51 AM

@a613
Copy link

a613 commented May 6, 2024

For a 2-second PR, I don't get why this is still an issue 6 years later. You don't even need to truncate on a word boundary, just literally slice the string to 200 chars or whatever. Even plaintext with no formatting would be better than the status quo.

Or even zero content, and just preview the title!

@michaelaflores
Copy link

I can't believe how long this issue has been open, but I'd like to chime in that the collective man-hours spent clicking the "x" to remove the preview due to these massive embeds is well worth the time to fix.

@nicolasassi
Copy link

Any advances about this? My team is considering dropping the integration all together as it just messes up the whole channel everyday

@1DanielC
Copy link

1DanielC commented Jul 9, 2024

Upvoting this. It would be nice to set preview length or drop the PR content in the preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests