Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] PR Slack notifier #83

Closed
zackkrida opened this issue Oct 1, 2021 · 8 comments · Fixed by #98
Closed

[Feature] PR Slack notifier #83

zackkrida opened this issue Oct 1, 2021 · 8 comments · Fixed by #98
Assignees
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@zackkrida
Copy link
Member

zackkrida commented Oct 1, 2021

Problem

We would like a way to see new Pull Requests in our PR slack channel. We don't want this integration to generate too much noise, these notifications are intended to be a quick, casual ping "hey, check out this new PR if you want!". The native GitHub Slack integration is not a good fit, it produces a "wall of text" response for each PR, with too much clutter.

Description

We could write a script in JS or Python in this repository, similar to @mkaz's work on TinkerNotifier, the bot for the tinker team (https://github.com/mkaz/octoack), that simply posts all new openverse-* repo pull requests to our slack channel, with a link.

We could use that bot, my initial thoughts for not using it are:

  • It's written in Rust, which isn't used by our other projects, so makes it more difficult to edit if needed
  • We'd have to host it, and I'm less sure about deploying/hosting/maintaining Rust applications, particularly as GitHub actions
  • It's a relatively simple piece of code to re-implement, and we already have similar scripts for working with the GitHub API
  • We might want to customize the output or emojis used 😆
  • We don't need user-level tracking, as is included in that script
@zackkrida zackkrida added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository labels Oct 1, 2021
@AetherUnbound
Copy link
Contributor

I thought we might be able to have the Tinker Bot accomplish this - do we need to write our own tool or can we use that?

@zackkrida
Copy link
Member Author

Just updated my initial comment with more detail @AetherUnbound 😄

@AetherUnbound
Copy link
Contributor

I wish there was a way to do a condensed preview using the default integration, but alas it seems like it's been an open issue for a while 😞

@dhruvkb dhruvkb self-assigned this Oct 2, 2021
@mkaz
Copy link
Member

mkaz commented Oct 2, 2021

I see it as an opportunity to play with Rust 😁

If you want to modify that existing script to support multiple accounts/repos/channels, I'll host it and run it on the same instance I'm running ours. I can help with any tweaks too, but also totally understand it's a simple easy script that rewriting in Python would be pretty quick.

@zackkrida
Copy link
Member Author

I'll host it and run it on the same instance I'm running ours.

Well that sounds easy 😄 let's go for it!

@mkaz
Copy link
Member

mkaz commented Oct 19, 2021

No Rust. 😢

@zackkrida
Copy link
Member Author

🦀 😢

@dhruvkb
Copy link
Member

dhruvkb commented Oct 19, 2021

Reject modernity. Return to shell. 😂

dhruvkb pushed a commit that referenced this issue Feb 20, 2023
…llib3-1.26.5

Bump urllib3 from 1.26.4 to 1.26.5 in /openverse-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants