Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: allow filtering of archived repos in github_organization #1826

Closed
1 task done
felixlut opened this issue Aug 6, 2023 · 1 comment · Fixed by #1833
Closed
1 task done

[FEAT]: allow filtering of archived repos in github_organization #1826

felixlut opened this issue Aug 6, 2023 · 1 comment · Fixed by #1833
Labels
Type: Feature New feature or request

Comments

@felixlut
Copy link
Contributor

felixlut commented Aug 6, 2023

Describe the need

Currently the github_organization datasource exposes all the repos of the org in the repositories attribute. I would like to make it possible to filter these repos based on whether they are archived or not. While this is possible to do afterwards, you'd have to make a second API call via a github_repository datasource, which I want to avoid.

My initial idea would be to add a ignore_archived_repos argument (defaulted to false if not explicitly set to not break current usage), which simply would simply filter the list returned in the repositories attribute to only return repos that aren't archived. I could also add a separate attribute called non-archived-repos or similar, returning both the filtered and unfiltered lists. I'm leaning towards the former approach, but I could be convinced to go the other way

And I could work on this.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@felixlut felixlut added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Aug 6, 2023
@kfcampbell
Copy link
Member

I also prefer the first approach!

@kfcampbell kfcampbell removed the Status: Triage This is being looked at and prioritized label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants