Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/github_repository: Allow updating default_branch #23

Merged
merged 2 commits into from
Jun 28, 2017

Conversation

grubernaut
Copy link
Contributor

Allows a user to update the default branch for a repository. This cannot be set during initial creation of the repository, and can only be configured during Updates to an existing repository. The GitHub API will also omit an error during Update if a corresponding ref is not found for the target branch.

$ make testacc TEST=./github TESTARGS="-run=TestAccGithubRepository_defaultBranch"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./github -v -run=TestAccGithubRepository_defaultBranch -timeout 120m
=== RUN   TestAccGithubRepository_defaultBranch
--- PASS: TestAccGithubRepository_defaultBranch (5.82s)
PASS
ok      github.com/terraform-providers/terraform-provider-github/github 5.826s

Fixes: #22

@grubernaut grubernaut added the Type: Feature New feature or request label Jun 28, 2017
Allows a user to update the default branch for a repository. This cannot be set during initial creation of the repository, and can only be configured during Updates to an existing repository. The GitHub API will also omit an error during Update if a corresponding ref is not found for the target branch.

```
$ make testacc TEST=./github TESTARGS="-run=TestAccGithubRepository_defaultBranch"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./github -v -run=TestAccGithubRepository_defaultBranch -timeout 120m
=== RUN   TestAccGithubRepository_defaultBranch
--- PASS: TestAccGithubRepository_defaultBranch (5.82s)
PASS
ok      github.com/terraform-providers/terraform-provider-github/github 5.826s
```
@apparentlymart
Copy link
Contributor

(looks like there's a vet error, though...)

@grubernaut grubernaut merged commit b5de42c into master Jun 28, 2017
@grubernaut grubernaut deleted the f-add-default-branch branch June 28, 2017 19:37
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
…ault-branch

r/github_repository: Allow updating default_branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants