Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting owner in anonymous mode #1029

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

kfcampbell
Copy link
Member

Fixes #647.

The provider currently doesn't respect any ownership configuration when running in anonymous mode. This is annoying because it blocks all kinds of uses, for example data sources retrieving public repos.

This PR makes a small change to respect ownership in anonymous mode, and now those data sources work!

@kfcampbell
Copy link
Member Author

cc @Olin-Vorechovsky I'd rather do this than error if there's no token present, since there's a lot of valid use cases for the provider without auth configured IMO. Thoughts?

@kfcampbell kfcampbell added the v5 label Jan 18, 2022
@kfcampbell kfcampbell removed the v5 label Jan 31, 2022
@kfcampbell kfcampbell added this to the v4.21.0 milestone Jan 31, 2022
@kfcampbell
Copy link
Member Author

I think this is a worthwhile change and since it's not breaking backwards compatibility, I've added it to a future milestone for release.

@kfcampbell kfcampbell modified the milestones: v4.21.0, v4.22.0 Mar 3, 2022
@kfcampbell
Copy link
Member Author

@jcudit let's talk about this in the next week or two!

@kfcampbell kfcampbell removed this from the v4.22.0 milestone Mar 18, 2022
@nickfloyd nickfloyd added the Status: Stale Used by stalebot to clean house label Nov 30, 2022
@nickfloyd
Copy link
Contributor

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Dec 1, 2022
@kfcampbell
Copy link
Member Author

I had forgotten about this! I think this is still relevant and should be merged.

@kfcampbell kfcampbell merged commit 1741133 into integrations:main Oct 27, 2023
3 checks passed
@kfcampbell kfcampbell deleted the allow-anonymous-owners branch October 27, 2023 20:55
@mnencia mnencia mentioned this pull request Dec 27, 2023
4 tasks
kfcampbell added a commit that referenced this pull request Jan 5, 2024
Resolves regressions #2008 and #2014 introduced in #1029

Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Resolves regressions integrations#2008 and integrations#2014 introduced in integrations#1029

Signed-off-by: Marco Nenciarini <mnencia@kcore.it>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform-import failure: Cannot import non-existent remote object
2 participants