Upgrade go-github to v43.0.0 #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
This looks good to me! I've made the same changes locally and I don't have a diff with your remote. Merging these sorts of PRs is always a bit tricky since they invite merge conflicts, so I'll probably end up cutting a release this Friday for the v4.23.0 milestone and then merging this sometime next week.
kfcampbell
added a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* upgrade go-github to v43.0.0 * include vendor files * Fix merge issue that introduced v42 again Co-authored-by: Keegan Campbell <me@kfcampbell.com>
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
* upgrade go-github to v43.0.0 * include vendor files * Fix merge issue that introduced v42 again Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades go-github to v43.0.0 from the current v42.0.0. Here are the release comments.
This is a prerequisite to fix #1045
It's been years since I've seriously touched go and the package management landscape has changed a lot, so let me know if I missed something or changed something on accident.