Resource: EMU External Groups Sync #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
commented
Apr 8, 2022
|
Going to merge this to create an alpha release for the EMUs feature. The changes should be purely additive and not affect other resources. |
kfcampbell
added a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* Initial commit of testing emus * Initial commit of creating EMU group mapping * Add read and delete operations * Tweaks to make updating work * Refactor coercion into reusable function * Simplify case logic * Add import logic * Whitespace change to test commit verification * Rework importation logic a bit * Bump to go-github v43 in EMU resource * Removing some extraneous whitespaces * Import logic mostly working * Fully fix import logic * Add docs and doc link * Remove time.Sleep * Remove vendoring hack as bug has been fixed * Remove extraneous comment in examples/emu
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
* Initial commit of testing emus * Initial commit of creating EMU group mapping * Add read and delete operations * Tweaks to make updating work * Refactor coercion into reusable function * Simplify case logic * Add import logic * Whitespace change to test commit verification * Rework importation logic a bit * Bump to go-github v43 in EMU resource * Removing some extraneous whitespaces * Import logic mostly working * Fully fix import logic * Add docs and doc link * Remove time.Sleep * Remove vendoring hack as bug has been fixed * Remove extraneous comment in examples/emu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1041.
This PR is ready to be merged as this hack is no longer necessary. I filed an issue internally about the discrepancy in what the API is returning for its time formats and that bug has now been fixed.
When I sat down to write integration tests for this, I realized that we don't have a good solution for integration testing EMUs, which is testing another integration (between GitHub and identity providers). Our current integration testing infra isn't exactly healthy, and this would be an extension of that. Long-term, that needs to change.