Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in branch protection's pull_request_bypassers test #1099

Merged

Conversation

reedloden
Copy link
Contributor

s/dismiss_stale_reviews/pull_request_bypassers/

@reedloden
Copy link
Contributor Author

I'm slightly concerned that this worked until now. Is this test actually testing the right thing?

@github-actions
Copy link

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Apr 24, 2023
@kfcampbell
Copy link
Member

@reedloden the short answer is that our tests are in an unhealthy state, as I've hinted at in #1414. These tests are not run automatically on PRs due to resource constraints. There was an attempt at labelling automation that could trigger test runs, though I don't have access to any of the test accounts configured. There's a long-overdue overhaul in testing waiting to be done, and it's particularly difficult in this instance due to the surface area of the provider and the resource costs of integration testing.

In any event, thank you for noticing and fixing this particular instance!

@kfcampbell kfcampbell merged commit a5bb4a4 into integrations:main May 1, 2023
3 checks passed
@reedloden reedloden deleted the reed/pull-request-bypass-test-fix branch May 1, 2023 22:19
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants