Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove incorrect required schema key on ref data source #1109

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

youcandanch
Copy link
Contributor

In #1084, I introduced a data source for refs, but it looks like the merged version is off an older commit I had pushed, which includes a required schema key on the data source that isn't used by the ref API. This PR introduces the correct code (along with a quick typo fix on the documentation).

Test output:

--- PASS: TestAccGithubRefDataSource (24.72s)
    --- PASS: TestAccGithubRefDataSource/queries_an_existing_branch_ref_without_error (12.40s)
        --- SKIP: TestAccGithubRefDataSource/queries_an_existing_branch_ref_without_error/with_an_anonymous_account (0.00s)
        --- PASS: TestAccGithubRefDataSource/queries_an_existing_branch_ref_without_error/with_an_individual_account (6.42s)
        --- PASS: TestAccGithubRefDataSource/queries_an_existing_branch_ref_without_error/with_an_organization_account (5.98s)
    --- PASS: TestAccGithubRefDataSource/queries_an_invalid_ref_without_error (12.31s)
        --- SKIP: TestAccGithubRefDataSource/queries_an_invalid_ref_without_error/with_an_anonymous_account (0.00s)
        --- PASS: TestAccGithubRefDataSource/queries_an_invalid_ref_without_error/with_an_individual_account (6.28s)
        --- PASS: TestAccGithubRefDataSource/queries_an_invalid_ref_without_error/with_an_organization_account (6.03s)
PASS
ok      github.com/integrations/terraform-provider-github/v4/github     24.745s

@youcandanch
Copy link
Contributor Author

@kfcampbell I've got some time this week to work on the prerelease stuff but would love to have this on the branch I'm working on, let me know if there's anything I can clarify on this one!

@kfcampbell kfcampbell added this to the v4.25.0 milestone Apr 28, 2022
@kfcampbell
Copy link
Member

@youcandanch Sorry for the delay, work has been crazy the past few weeks. I'll have this merged in and released shortly; thank you for the update!

@kfcampbell kfcampbell merged commit 9bc16d5 into integrations:main Apr 28, 2022
@youcandanch youcandanch deleted the fix-1108 branch April 29, 2022 02:53
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants