feat: allow_update_branch argument #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strantalis
force-pushed
the
feat/always-suggest-updating-pr
branch
from
12ab6ed
to
4150a09
Compare
bateller
approved these changes
Jun 7, 2022
|
The dependent PR (#1138) has been merged, so I think nothing blocks this PR from being finalized and merged. @strantalis do you have time to fix the conflicts? |
|
@rene-bos Yeah I can get those fixed this week. |
setting allows toggling "always suggest updating pull request branch" repository setting Signed-off-by: Sean Trantalis <strantalis@virtru.com>
strantalis
force-pushed
the
feat/always-suggest-updating-pr
branch
from
4150a09
to
d21bba0
Compare
|
When could this PR be merged? |
|
@bateller Can you approve the workflow? I'm hoping to see this PR merged soon, since it's blocking some work I have planned |
|
This would be great to be included in the next release :) |
bateller
approved these changes
Oct 14, 2022
|
Hi, I just stumbled upon this PR, great job 🎉 ! Looking forward to a merge 😁 |
|
I've updated the PR and fixed the merge conflict. I love this feature and we have it enabled on this repo! This will be released shortly. |
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
setting allows toggling "always suggest updating pull request branch" repository setting Signed-off-by: Sean Trantalis <strantalis@virtru.com> Signed-off-by: Sean Trantalis <strantalis@virtru.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
setting allows toggling "always suggest updating pull request branch" repository setting Signed-off-by: Sean Trantalis <strantalis@virtru.com> Signed-off-by: Sean Trantalis <strantalis@virtru.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument allows toggling
Always suggest updating pull request branchin the repository settings. Closes #1072 but is dependent by #1138 as this needsv44ofgo-github.