fix(repository): don't perform additional request for security info #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Security and Analysis information should also be returned by a GET of the Repository, so another request (and especially Edit) should not be needed. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
seuros
approved these changes
Nov 25, 2022
kfcampbell
approved these changes
Nov 29, 2022
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
…ntegrations#1388) The Security and Analysis information should also be returned by a GET of the Repository, so another request (and especially Edit) should not be needed. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org> Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
1 task
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…ntegrations#1388) The Security and Analysis information should also be returned by a GET of the Repository, so another request (and especially Edit) should not be needed. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org> Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Security and Analysis information should also be returned by a GET of the Repository, so another request (and especially Edit) should not be needed.
Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org
Resolves #1387
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug