URL encode environment name in github_repository_environment

[Sebelino]

Resolves #1389

---

Behavior

Before the change?

Any attempt to create, read, update or delete a repository environment with a name that contains a / or other special characters would fail.

After the change?

Attempts to create, read, update or delete a repository environment with a name that contains a / or other special characters will succeed.

Other information

• Not sure if this should instead be fixed upstream, in https://github.com/google/go-github, or if it is the responsibility of the client to URL encode the input.

---

Additional info

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes (Please add the Type: Breaking change label)
• No

If Yes, what's the impact:

• Users of this resource may need to update their configuration to make sure that the environment name is not URL encoded twice. In other words, they may need to change e.g.:

resource "github_repository_environment" "this" {
  environment = urlencode("environment/test")
  repository  = "my-repo"
}

into:

resource "github_repository_environment" "this" {
  environment = "environment/test"
  repository  = "my-repo"
}

assuming they have environment names that contain special characters.

Pull request type

Please add the corresponding label for change this PR introduces:

• Bugfix: Type: Bug
• Feature/model/API additions: Type: Feature
• Updates to docs or samples: Type: Documentation
• Dependencies/code cleanup: Type: Maintenance

---

[kfcampbell]

Confirming acceptance tests are passing for me locally. Thank you for contributing!