Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates workflow to use PR targets for RW workflow actions #1427

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

nickfloyd
Copy link
Contributor

From: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

Warning: For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission unless the permissions key is specified and the workflow can access secrets, even when it is triggered from a fork. Although the workflow runs in the context of the base of the pull request, you should make sure that you do not check out, build, or run untrusted code from the pull request with this event. Additionally, any caches share the same scope as the base branch. To help prevent cache poisoning, you should not save the cache if there is a possibility that the cache contents were altered. For more information, see "Keeping your GitHub Actions and workflows secure: Preventing pwn requests" on the GitHub Security Lab website.

We need this action to be read/write.

@nickfloyd nickfloyd added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Dec 12, 2022
@nickfloyd nickfloyd changed the title Updates workflow to use PR targets for RW wrokflow actions Updates workflow to use PR targets for RW workflow actions Dec 12, 2022
@kfcampbell
Copy link
Member

This looks good, thank you!

@kfcampbell kfcampbell merged commit 094ea77 into main Dec 12, 2022
@kfcampbell kfcampbell deleted the update-add-to-project-rw branch December 12, 2022 21:28
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants