Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add parent team attributes to teams datasource #1452

Merged
merged 2 commits into from
Jan 3, 2023
Merged

feat: add parent team attributes to teams datasource #1452

merged 2 commits into from
Jan 3, 2023

Conversation

jbdelpech
Copy link
Contributor

@jbdelpech jbdelpech commented Dec 23, 2022 •
edited

Behavior

Before the change?

  • Parent team is not returned

After the change?

  • When getting teams from datasource, return for each team the parent team with the following attributes: ID, slug, name.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@jbdelpech jbdelpech force-pushed the feat/add-parent-team-attributes branch from 7a3e948 to 9ef31ce Compare December 23, 2022 14:51
@jbdelpech jbdelpech marked this pull request as ready for review December 23, 2022 14:52
@jbdelpech jbdelpech changed the title feat: add parent team attributes to teams feat: add parent team attributes to teams datasource Dec 23, 2022
@nickfloyd nickfloyd added the Type: Feature New feature or request label Dec 30, 2022
@jbdelpech jbdelpech force-pushed the feat/add-parent-team-attributes branch from 9ef31ce to 81409f6 Compare January 2, 2023 13:08
kfcampbell
kfcampbell approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming integration tests are passing for me locally. Thank you for contributing!

@kfcampbell kfcampbell merged commit b01ad9d into integrations:main Jan 3, 2023
@jbdelpech jbdelpech deleted the feat/add-parent-team-attributes branch January 4, 2023 11:50
This was referenced Jun 28, 2023
Open
Closed
Closed
@renovate renovate bot mentioned this pull request Jul 12, 2023
Open
1 task
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@jbdelpech @kfcampbell
feat: add parent team attributes to teams (integrations#1452)
82db1a6 
Co-authored-by: Jean-Baptiste Delpech <jbdelpech@users.noreply.github.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbdelpech @kfcampbell @nickfloyd