feat: Add support for GitHub Actions OpenID Connect subject claim customization templates #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label Type: Feature |
nickfloyd
added
Type: Feature
|
@F21 Thank you for these contributions ❤️. We'll wait to do the final review/merge until they drop a new version of go-GitHub and it gets updated here! |
…tomization templates
|
A new release of |
|
@F21 do you mind doing me a favor when you get a moment? It would be awesome to put links to the new docs you created in the github.erb file so they're linked and more easily accessible to users. This recent PR shows an example. |
5 tasks
5 tasks
|
Thanks for the quick review and merge @nickfloyd and @kfcampbell ! The follow-up PR to add the missing links is in #1480. |
|
I've merged #1480 and will release it soon, at the same time as this PR. |
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…omization-template feat: Add support for GitHub Actions OpenID Connect subject claim customization templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1458
Behavior
This adds support for OpenID Connect subject claim customization templates for GitHub Actions.
More information regarding this feature here: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect
Note: This requires features I recently committed to google/go-github, which are currently unreleased, so it pins google/go-github toe4ff2a27f7699954c87d81d723012c1c3f0de0f1. The PR will be updated to pin a released version ofgo-githubas soon as the maintainers tag a new release.Before the change?
It was not possible to manage OpenID Connect subject claim customization templates for GitHub Actions using Terraform.
After the change?
This change adds 2 resources and 2 data sources for managing OpenID Connect subject claim customization templates on an organization and repository basis:
github_actions_organization_oidc_subject_claim_customization_templategithub_actions_repository_oidc_subject_claim_customization_templatedata.github_actions_organization_oidc_subject_claim_customization_templatedata.github_actions_repository_oidc_subject_claim_customization_templateOther information
None.
Additional info
Pull request checklist
Does this introduce a breaking change?
Type: Breaking changelabel)Pull request type
Please add the corresponding label for change this PR introduces:
Type: FeatureType: Documentation