Add support for github actions variables #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure if there was a process to auto-generate the docs for the new resources/data sources. If not just let me know and I can try and write some. |
5 tasks
|
I added in support for importing existing variables as well as the new docs pages. Should be ready for a review at this point. |
kfcampbell
reviewed
Feb 28, 2023
There was a problem hiding this comment.
This looks really good, thank you @tjcorr! If you don't want to/don't have time to link the docs, let me know and I can take care of it before getting this in.
|
Thank you very much @tjcorr! Can't wait for the release. |
1 task
kfcampbell
approved these changes
Mar 10, 2023
1 task
reedloden
pushed a commit
to reedloden/terraform-provider-github
that referenced
this pull request
Jun 14, 2023
* add support for github actions variables * adding importers and website documentation * Run go mod tidy * update website nav with new pages --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
bazaah
added a commit
to amachsoftware/terraform-github-repository
that referenced
this pull request
Aug 9, 2023
From v4.20, to support the usage of the action_variable resource (included in v5.18.3) References: https://github.com/integrations/terraform-provider-github/releases/tag/v5.18.3 References: integrations/terraform-provider-github#1569
bazaah
added a commit
to amachsoftware/terraform-github-repository
that referenced
this pull request
Aug 9, 2023
From v4.20, to support the usage of the action_variable resource (included in v5.18.3) References: https://github.com/integrations/terraform-provider-github/releases/tag/v5.18.3 References: integrations/terraform-provider-github#1569
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* add support for github actions variables * adding importers and website documentation * Run go mod tidy * update website nav with new pages --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1534
Behavior
After the change?
Adds 3 new resources to support GitHub Actions variables at the repo, environment, and organization levels:
github_actions_variablegithub_actions_environment_variablegithub_actions_organization_variableIn addition this also adds the corresponding data sources:
github_actions_variablesgithub_actions_environment_variablesgithub_actions_organization_variablesAs well as the missing data source
github_actions_environment_secretsOther information
This required an update to a new version of the github.com/google/go-github/v50 module (now v50.1.0) to support the new APIs.
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance