make github_ref respect owner
#1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we discussed on Slack, let's try making the owner optional so that we can release this as a non-breaking change. Would you like to do that? Should I push commits to this PR? |
|
Psst...hi! I don't want to step on your toes here but it would be great to get this in soon. Want me to make the owner optional? |
|
I'd love to get this in ASAP, too! This week and early of next are fully booked, so if you can get to it earlier, please do! |
1 task
kfcampbell
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
I've tested this locally and it works! This is a change we probably need to make across many resources. I've opened #1655 to track this work.
Thank you for contributing!
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* make `github_ref` respect `owner` (instead of deriving it from the token) * `id` is also exported and should be mentioned * If no owner specified, use owner of token --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainers 👋🏼
Resolves #1650
Behavior
Before the change?
github_refdata source is not able to provide data on repositories that are not of the same owner as the PAT / tokenAfter the change?
github_refdata source is able to provide data on repositories that are not of the same owner as the PAT / tokenOther information
Additional info
Pull request checklist
Does this introduce a breaking change?
The
github_refdata source now requires anownerattribute. I marked it asrequiredin the code, which brings this data source in line with other data sources.Not providing an
ownerwould result in Terraform informing the user of a missing attribute (owner), which could break a deployment.Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:github_refdata source, anownerattribute must now be provided.Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug