Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(github_team): Invalid interface conversion on parent_team_id #1673

Merged
merged 2 commits into from
May 5, 2023
Merged

fix(github_team): Invalid interface conversion on parent_team_id #1673

merged 2 commits into from
May 5, 2023

Conversation

dion-gionet
Copy link
Contributor

Resolves #1672

Behavior

Before the change?

  • Invalid interface conversion on github_team.parent_team_id

After the change?

  • Applies without crashing

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

kfcampbell
kfcampbell approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@kfcampbell kfcampbell merged commit 37e89df into integrations:main May 5, 2023
3 checks passed
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@dion-gionet @kfcampbell
fix(github_team): Invalid interface conversion on parent_team_id (int…
027336d 
…egrations#1673)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Invalid interface conversion on github_team.parent_team_id
2 participants
@dion-gionet @kfcampbell