Fix #1555: Avoid duplication of pull request bypasser #1711
Conversation
|
Hello @kfcampbell. This patch works for me, but I'm not able to have green test with |
bpaquet
changed the title
|
I will be happy to add tests if I'm able to have them green before :) |
|
🙈 🙈 🙈 Our branch protection tests are a bit of a mess, unfortunately. If you can provide a reproduction case I can use to manually test this, I'll consider that acceptable. |
hello @kfcampbell Can you try this? https://github.com/bpaquet/terraform-provider-github/tree/test_bypasser/examples/repo_branch_protection ? I cannot check it on my side, because my test org is not pro, but I'm confident this will highlight the issue. Just run two apply, or one apply and a plan after. Thx :) |
There was a problem hiding this comment.
Thanks @bpaquet! I've validated that this does fix the issue in which subsequent applies wanted to remove the actor ID. This is good to go.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://togithub.com/integrations/terraform-provider-github)) | required_provider | patch | `5.28.0` -> `5.28.1` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v5.28.1`](https://togithub.com/integrations/terraform-provider-github/releases/tag/v5.28.1) [Compare Source](https://togithub.com/integrations/terraform-provider-github/compare/v5.28.0...v5.28.1) #### What's Changed - build(deps): bump github.com/google/go-github/v53 from 53.0.0 to 53.1.0 by [@​dependabot](https://togithub.com/dependabot) in [integrations/terraform-provider-github#1740 - build(deps): bump golang.org/x/oauth2 from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [integrations/terraform-provider-github#1739 - Improve github team resource by [@​bpaquet](https://togithub.com/bpaquet) in [integrations/terraform-provider-github#1722 - Handle deployment branch policies for repositories: resources and datasource by [@​bpaquet](https://togithub.com/bpaquet) in [integrations/terraform-provider-github#1715 - Bump google/go-github to v53.2.0 by [@​kfcampbell](https://togithub.com/kfcampbell) in [integrations/terraform-provider-github#1744 - Fix [#​1555](https://togithub.com/integrations/terraform-provider-github/issues/1555): Avoid duplication of pull request bypasser by [@​bpaquet](https://togithub.com/bpaquet) in [integrations/terraform-provider-github#1711 - fix: Repo Creation fails with enabled Pages by [@​0x46616c6b](https://togithub.com/0x46616c6b) in [integrations/terraform-provider-github#1748 **Full Changelog**: integrations/terraform-provider-github@v5.28.0...v5.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDAuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0MC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: greyrock-bot <1583719+greyrock-bot[bot]@users.noreply.github.com>
…ntegrations#1711) Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Fix #1555
This one line patch avoid to duplicate pull request bypasser while reading branch protection.