Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added resource github_actions_default_workflow_repository_permissions #1792

Conversation

petergvizd-s1
Copy link

@petergvizd-s1 petergvizd-s1 commented Jul 12, 2023

Resolves #1266


Behavior

Added resource for setting default workflow permissions for repository via API calls

Before the change?

  • Currently there is no resource for managing default workflow permissions for repository

After the change?

  • Added resource github_actions_default_workflow_repository_permissions for setting default workflow permissions for repository

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@petergvizd-s1 petergvizd-s1 force-pushed the feat-Added-resource-github-actions-default-workflow-repository-permissions branch from 1f1a80e to 381aeeb Compare July 12, 2023 22:33
@petergvizd-s1 petergvizd-s1 force-pushed the feat-Added-resource-github-actions-default-workflow-repository-permissions branch from 381aeeb to 5021251 Compare July 12, 2023 22:44
@petergvizd-s1 petergvizd-s1 marked this pull request as ready for review July 12, 2023 22:45
@@ -166,6 +166,22 @@ func (a *ActionsPermissionsRepository) GetEnabled() bool {
return *a.Enabled
}

// GetDefaultWorkflowPermissions returns the DefaultWorkflowPermissions field if it's non-nil, zero value otherwise.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make these updates to vendored files manually? How did this come about without associated go.mod and go.sum files?

@kfcampbell
Copy link
Member

@petergvizd-s1 I'm going to close this now since it's been sitting for a while; please reopen if you'd like to continue this work.

@kfcampbell kfcampbell closed this Oct 17, 2023
@saminahbab
Copy link

This should really be opened again, as it is not possible in my use case to use terraform to create repositories and create github actions workflows that can push branches in semantic release

@prores-raypet
Copy link

Why was this closed? It's exactly what we need for terraforming our projects properly.

@kfcampbell
Copy link
Member

I closed the PR as it was abandoned. Please feel free to take the work and reopen a similar PR if you'd like to drive it forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: set Repo default workflow permissions
4 participants