-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add owner attribute for repository resource #1832
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomas Dabasinskas <tomas@dabasinskas.net> Took 3 hours 5 minutes
Signed-off-by: Tomas Dabasinskas <tomas@dabasinskas.net> Took 13 minutes
This seems like a good approach to the change to me, though I also feel somewhat uncomfortable without integration tests. |
Hey @tdabasinskas, just a quick follow up. Is this something that you are interested in wrapping up?
Thanks again for making things better for the community here! ❤️ |
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Hi @nickfloyd, Sorry for dropping a ball on this. I've updated the docs as per @kfcampbell proposal. However, I'm not sure when I could do the integration tests, and, more importantly, add this to all the rest of repository-related resources. Being able to set |
I definitely agree with this take, and this is something the provider can stand to do a lot better on. We'd definitely be receptive to anybody wanting to continue this work. |
Hey every, just a heads up - I merged this branch into my own and am continuing this work there. Feedback welcome! |
An attempt to fix #1702.
The lack of ability to specify
owner
for an individual repository resource makes this provider pretty much unusable in a GHES environment containing over 300 organizations – having a separate provider for every single organization is probably not a great idea.I'm not sure my solution is ideal – the current code is quite biased on the owner being resolved automatically, so it's a bit challenging to add support for an explicit owner without introducing a breaking change.
I've tested this quite extensively manually – seems to be working as expected. If someone could help with adding some tests to confirm this, I would appreciate. Also, these changes should be applied to all
repository_
resources, but prior to doing that, I wanted to get some feedback.Before the change?
repository
resource usesowner
specified at the provider level.After the change?
repository
resource supports an optionalowner
argument.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!