This repository has been archived by the owner on Jan 11, 2018. It is now read-only.
Start notification support #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds optional Notifier#notify_build_started method which notifiers can implement to do whatever they want when a build starts. (ex: send a message to a service saying "Build has started for...") * Does not change API for existing notifiers (#notify is still called/supported for other notifiers)
|
Thank you for the pull request - it has been merged in. Additionally, several tickets have been closed and |
|
Cool. Thanks, man! |
|
Thank you so much! Hopefully you haven't abandoned Integrity in the last year - or if you have, you'll take a look at it again :) I'd appreciate any comments/suggestions/pull requests you could submit! Thank you again, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the start notifications changeset off of HEAD and pushed to "start_notifications" branch on my fork (closes issue #41). There are a few details in the full commit message (see: http://github.com/tomkersten/integrity/commit/69d882554b35e931b352d821d9ad3cd1311d5c1a vs. the single-line message you are shown by default on commits).
Let me know what you think.