Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python auto test #1834

Merged
merged 24 commits into from
Dec 17, 2019
Merged

Add python auto test #1834

merged 24 commits into from
Dec 17, 2019

Conversation

aqtjin
Copy link
Contributor

@aqtjin aqtjin commented Dec 11, 2019

Non-pip

  • attention example (keras2)
  • autograd customloss example
  • openvino example
  • vnni/openvino example
  • streaming object detection example
  • streaming text classification example

pip

  • attention example (keras2)
  • openvino example
  • vnni/openvino example
  • streaming object detection example
  • streaming text classification example

unzip -q analytics-zoo-data/data/streaming/text-model.zip -d analytics-zoo-data/data/streaming/
fi
export SPARK_DRIVER_MEMORY=2g
nc -lk 9000 < analytics-zoo-data/data/streaming/text-model/2.log &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this command work for docker?

exit $exit_status
fi

unset SPARK_DRIVER_MEMORY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unset is unnecessary. Unless this env will cause problems. It will be override by new values.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is necessary to remove side effect of one test in order to influence other tests. Otherwise if a following test forgets to set memory, then using the old memory can still pass, but it is very likely that memory requirement is not included when running by users.

pyzoo/zoo/examples/run-example-tests-keras2.sh Outdated Show resolved Hide resolved
pyzoo/zoo/examples/run-example-tests-pip.sh Outdated Show resolved Hide resolved
@@ -484,6 +486,168 @@ unset SPARK_DRIVER_MEMORY
now=$(date "+%s")
time10=$((now-start))

#echo "#11 start example test for openvino"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this passed?

pyzoo/zoo/examples/run-example-tests-pip.sh Outdated Show resolved Hide resolved
pyzoo/zoo/examples/run-example-tests-pip.sh Show resolved Hide resolved
pyzoo/zoo/examples/run-example-tests.sh Outdated Show resolved Hide resolved
pyzoo/zoo/examples/run-example-tests.sh Outdated Show resolved Hide resolved
pyzoo/zoo/examples/run-example-tests.sh Show resolved Hide resolved
@hkvision
Copy link
Contributor

jenkins?

export ANALYTICS_ZOO_HOME=$ANALYTICS_ZOO_ROOT/dist
export ANALYTICS_ZOO_JAR=`find ${ANALYTICS_ZOO_HOME}/lib -type f -name "analytics-zoo*jar-with-dependencies.jar"`
export ANALYTICS_ZOO_PYZIP=`find ${ANALYTICS_ZOO_HOME}/lib -type f -name "analytics-zoo*python-api.zip"`
export ANALYTICS_ZOO_CONF=${ANALYTICS_ZOO_HOME}/conf/spark-analytics-zoo.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these needed?

Copy link
Contributor

@hkvision hkvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qiyuangong qiyuangong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkvision hkvision merged commit e3cc766 into intel-analytics:master Dec 17, 2019
sgwhat pushed a commit to sgwhat/analytics-zoo that referenced this pull request Oct 9, 2021
* auto-test

* fix openvino memory

* fix openvino memory

* keras2

* fix keras2

* fix

* fix

* fix k2

* fix k2

* temporary version

* test for intel-analytics#6

* keras test

* test nc

* test nc

* final

* final fix

* final fix

* ffffinal fix

* fix

* f

* f
dding3 pushed a commit that referenced this pull request Oct 13, 2021
* auto-test

* fix openvino memory

* fix openvino memory

* keras2

* fix keras2

* fix

* fix

* fix k2

* fix k2

* temporary version

* test for #6

* keras test

* test nc

* test nc

* final

* final fix

* final fix

* ffffinal fix

* fix

* f

* f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants