-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python auto test #1834
Add python auto test #1834
Conversation
unzip -q analytics-zoo-data/data/streaming/text-model.zip -d analytics-zoo-data/data/streaming/ | ||
fi | ||
export SPARK_DRIVER_MEMORY=2g | ||
nc -lk 9000 < analytics-zoo-data/data/streaming/text-model/2.log & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this command work for docker?
exit $exit_status | ||
fi | ||
|
||
unset SPARK_DRIVER_MEMORY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unset is unnecessary. Unless this env will cause problems. It will be override by new values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is necessary to remove side effect of one test in order to influence other tests. Otherwise if a following test forgets to set memory, then using the old memory can still pass, but it is very likely that memory requirement is not included when running by users.
@@ -484,6 +486,168 @@ unset SPARK_DRIVER_MEMORY | |||
now=$(date "+%s") | |||
time10=$((now-start)) | |||
|
|||
#echo "#11 start example test for openvino" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this passed?
jenkins? |
export ANALYTICS_ZOO_HOME=$ANALYTICS_ZOO_ROOT/dist | ||
export ANALYTICS_ZOO_JAR=`find ${ANALYTICS_ZOO_HOME}/lib -type f -name "analytics-zoo*jar-with-dependencies.jar"` | ||
export ANALYTICS_ZOO_PYZIP=`find ${ANALYTICS_ZOO_HOME}/lib -type f -name "analytics-zoo*python-api.zip"` | ||
export ANALYTICS_ZOO_CONF=${ANALYTICS_ZOO_HOME}/conf/spark-analytics-zoo.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* auto-test * fix openvino memory * fix openvino memory * keras2 * fix keras2 * fix * fix * fix k2 * fix k2 * temporary version * test for intel-analytics#6 * keras test * test nc * test nc * final * final fix * final fix * ffffinal fix * fix * f * f
* auto-test * fix openvino memory * fix openvino memory * keras2 * fix keras2 * fix * fix * fix k2 * fix k2 * temporary version * test for #6 * keras test * test nc * test nc * final * final fix * final fix * ffffinal fix * fix * f * f
Non-pip
pip