Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Module:backward() final #25

Open
jason-dai opened this issue Sep 27, 2016 · 2 comments
Open

Make Module:backward() final #25

jason-dai opened this issue Sep 27, 2016 · 2 comments

Comments

@jason-dai
Copy link
Contributor

We should make Module:backward final, and overload the updategradInput and accGradParameters methods in its subclasses instead.

@jason-dai jason-dai added this to the 0.1 release milestone Jan 9, 2017
@jason-dai jason-dai removed this from the 0.1 release milestone Jan 9, 2017
@zhichao-li
Copy link
Contributor

A similar one need to be final: #966

@yiheng
Copy link
Contributor

yiheng commented Jun 8, 2017

Forward and backward should be final for all non-container layers. The non-container layer should only override updateOutput(), updateGradInput() and accGrad(). Some common logic(e.g. bypass the layer/freeze the parameter) should be put into the forward/backward method and not be changed by the non-container layers.

Forward/Backward should be overridden in container layers. In container forward/backward method, the submodules should always call forward/backward method of the submodule.

wzhongyuan pushed a commit to wzhongyuan/BigDL that referenced this issue Jan 16, 2019
* fix: wrong usage of omp_get_num_threads.

omp_get_num_threads will return how many threads in current team. For
sequential code, it always return 1. In mkl.c, it's a sequential mode.
There are two ways to solve this:

1. get the value in a parallel mode
2. call omp_max_num_threads

* test: add test case
Le-Zheng pushed a commit to Le-Zheng/BigDL that referenced this issue Oct 20, 2021
* add scala object detection api and examples
Oscilloscope98 pushed a commit to Oscilloscope98/ipex-llm that referenced this issue Oct 17, 2022
liu-shaojun pushed a commit that referenced this issue Mar 25, 2024
* update setup.py

* add new action

* add compatible mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants