Fix Baichuan2 prompt format #10334
Merged
Fix Baichuan2 prompt format #10334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkvision
approved these changes
Mar 6, 2024
plusbang
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Please also update the prompt format in https://github.com/intel-analytics/BigDL/blob/main/python/llm/example/GPU/PyTorch-Models/Model/baichuan2/generate.py#L25
Have updated README and |
hkvision
reviewed
Mar 19, 2024
Comment on lines
27
to
28
| # Though this is the official prompt format, we found it has problem generating English answers | ||
| # If you want to ask English questions, we recommend you to change the prompt format |
There was a problem hiding this comment.
For English prompt, you are recommended to change the prompt format.
This was referenced Mar 19, 2024
liu-shaojun
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Fix Baichuan2 prompt format * Fix Baichuan2 README * Change baichuan2 prompt info * Change baichuan2 prompt info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Baichuan2 prompt format referred from link1 and link2.