ConcatTable Identity and CAddTable #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiheng
reviewed
Nov 2, 2016
| output = if (inplace) { | ||
| input.get[Tensor[T]](1).get | ||
| } else { | ||
| val input1 = input.get[Tensor[T]](1).get |
There was a problem hiding this comment.
you can use Table.apply here. Same in other places
| i += 1 | ||
| } | ||
|
|
||
| while(i <= gradInput.length()) { |
There was a problem hiding this comment.
What's this line for? Shouldn't gradInput.length == input.length???
| class CAddTable[@specialized(Float, Double) T: ClassTag](val inplace: Boolean = false)( | ||
| implicit ev: TensorNumeric[T]) extends Module[Table, Tensor[T], T] { | ||
|
|
||
| gradInput = T() |
| class ConcatTable[T : ClassTag](implicit ev: TensorNumeric[T]) | ||
| extends Container[Activities, Activities, T] { | ||
|
|
||
| output = T() |
| var i = 0 | ||
| while (i < modules.length) { | ||
| val currentOutput = modules(i).updateOutput(input) | ||
| if (!output.toTable().contains(i + 1)) { |
There was a problem hiding this comment.
put output.toTable into a variable?
| } else { | ||
| var i = 1 | ||
| while (i <= out.toTable().length()) { | ||
| addTable(out.toTable().get[Activities](i).get, in.toTable().get[Activities](i).get) |
| if (in.isInstanceOf[Tensor[T]]) { | ||
| in.toTensor[T]().clone() | ||
| } else { | ||
| val out = T() |
| } | ||
| } | ||
|
|
||
| def backward(method: String, input: Activities, gradOutput: Activities, |
There was a problem hiding this comment.
Can we avoid override this???
There was a problem hiding this comment.
It's not override. But it's more confusing
| scale : Double = 1.0) : Activities = { | ||
|
|
||
| val isTable = input.isInstanceOf[Table] | ||
| val wasTable = gradInput.isInstanceOf[Table] |
There was a problem hiding this comment.
rename the varibale to isInputTable/isGradInputTable. The name is silly!
| } | ||
| var i = 0 | ||
| while (i < modules.length) { | ||
| method match { |
There was a problem hiding this comment.
don't do this in Java/Scala!
qiuxin2012
force-pushed
the
master
branch
2 times, most recently
from
7a352b4
to
2cdbabf
Compare
wzhongyuan
pushed a commit
to wzhongyuan/BigDL
that referenced
this pull request
Jan 16, 2019
* feat: mkl-dnn initialize * fix: structure of building * fix: public final static * fix: delete the dependencies of environments * fix: skip tests * add update dnn wrappers * fix: dynamic load iomp5 * feat linear supports and some fix * add more wrapper * add lrn api * fix: add bn and softmax * fix: some fixes * fix: mkl-dnn build * feat: add get format api * fix: add getSize * feat: aligned memory * add conv fuse relu api * fix: add aligned storage * add concat api * fix: mkl envs for lib mkldnn * fix: add mkl add method with 2 ptrs * fix: update to Release * fix: batch norm infer mode * fix: update 0.5.0 -> 0.6.0 * add free (intel-analytics#5) * feat: affinity for java thread * fix: update core branch * fix: delete the memset constant value for debug, and add affinity * feat: add mkl-dnn fusion * fix: memory format enum consistent with dnn * feat: add auto format * refactor: delete the MemoryFormat in MklDnn * Memory should load MKLDnn (intel-analytics#6) * refactor: move enums to seprate classes (intel-analytics#7) * feat: add GetShape and GetFormat api * fix: delete printf * fix a bug * add sum * refactor: change name * refactor: change submodule infos * fix: set block time by default. A property to control to disable it
Le-Zheng
pushed a commit
to Le-Zheng/BigDL
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eltwise layer(sum) in caffe