-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add octree I/O support for json #911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @germanros1987, @syncle, @takanokage, and @yxlao)
a discussion (no related file):
Can we make it a recursive json structure?
Then you just need to make OcTreeNode as IJsonConvertible, then you call Traverse, it solves the problem, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @germanros1987, @qianyizh, and @takanokage)
a discussion (no related file):
Previously, qianyizh (Qianyi Zhou) wrote…
Can we make it a recursive json structure?
Then you just need to make OcTreeNode as IJsonConvertible, then you call Traverse, it solves the problem, yes?
Same comment. Other than that, it looks good to me.
@yxlao any follow up on this? |
1085369
to
7bb5eb8
Compare
@qianyizh comments addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @germanros1987, @qianyizh, and @takanokage)
Add octree I/O support for json (ascii output). Based on #903, merge #903 first.
Example json output
This change is