Skip to content

Commit

Permalink
iov_iter: copy_folio_from_iter_atomic()
Browse files Browse the repository at this point in the history
Add a foliated version of copy_page_from_iter_atomic()

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Matthew Wilcox <willy@infradead.org>
  • Loading branch information
Kent Overstreet authored and intel-lab-lkp committed May 9, 2023
1 parent c41f581 commit 0e5d422
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 10 deletions.
2 changes: 2 additions & 0 deletions include/linux/uio.h
Expand Up @@ -154,6 +154,8 @@ static inline struct iovec iov_iter_iovec(const struct iov_iter *iter)

size_t copy_page_from_iter_atomic(struct page *page, unsigned offset,
size_t bytes, struct iov_iter *i);
size_t copy_folio_from_iter_atomic(struct folio *folio, size_t offset,
size_t bytes, struct iov_iter *i);
void iov_iter_advance(struct iov_iter *i, size_t bytes);
void iov_iter_revert(struct iov_iter *i, size_t bytes);
size_t fault_in_iov_iter_readable(const struct iov_iter *i, size_t bytes);
Expand Down
53 changes: 43 additions & 10 deletions lib/iov_iter.c
Expand Up @@ -800,27 +800,60 @@ size_t iov_iter_zero(size_t bytes, struct iov_iter *i)
}
EXPORT_SYMBOL(iov_iter_zero);

size_t copy_page_from_iter_atomic(struct page *page, unsigned offset, size_t bytes,
struct iov_iter *i)
static inline size_t __copy_page_from_iter_atomic(struct page *page, unsigned offset,
size_t bytes, struct iov_iter *i)
{
char *kaddr = kmap_atomic(page), *p = kaddr + offset;
if (!page_copy_sane(page, offset, bytes)) {
kunmap_atomic(kaddr);
return 0;
}
if (WARN_ON_ONCE(!i->data_source)) {
kunmap_atomic(kaddr);
return 0;
}
iterate_and_advance(i, bytes, base, len, off,
copyin(p + off, base, len),
memcpy(p + off, base, len)
)
kunmap_atomic(kaddr);
return bytes;
}

size_t copy_page_from_iter_atomic(struct page *page, unsigned offset, size_t bytes,
struct iov_iter *i)
{
if (!page_copy_sane(page, offset, bytes))
return 0;
if (WARN_ON_ONCE(!i->data_source))
return 0;
return __copy_page_from_iter_atomic(page, offset, bytes, i);
}
EXPORT_SYMBOL(copy_page_from_iter_atomic);

size_t copy_folio_from_iter_atomic(struct folio *folio, size_t offset,
size_t bytes, struct iov_iter *i)
{
size_t ret = 0;

if (WARN_ON(offset + bytes > folio_size(folio)))
return 0;
if (WARN_ON_ONCE(!i->data_source))
return 0;

#ifdef CONFIG_HIGHMEM
while (bytes) {
struct page *page = folio_page(folio, offset >> PAGE_SHIFT);
unsigned b = min(bytes, PAGE_SIZE - (offset & PAGE_MASK));
unsigned r = __copy_page_from_iter_atomic(page, offset, b, i);

offset += r;
bytes -= r;
ret += r;

if (r != b)
break;
}
#else
ret = __copy_page_from_iter_atomic(&folio->page, offset, bytes, i);
#endif

return ret;
}
EXPORT_SYMBOL(copy_folio_from_iter_atomic);

static void pipe_advance(struct iov_iter *i, size_t size)
{
struct pipe_inode_info *pipe = i->pipe;
Expand Down

0 comments on commit 0e5d422

Please sign in to comment.