Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fs/select: mark do_select noinline_for_stack for 32b
Effectively a revert of commit ad312f9 ("fs/select: avoid clang stack usage warning") Various configs can still push the stack useage of core_sys_select() over the CONFIG_FRAME_WARN threshold (1024B on 32b targets). fs/select.c:619:5: error: stack frame size of 1048 bytes in function 'core_sys_select' [-Werror,-Wframe-larger-than=] core_sys_select() has a large stack allocation for `stack_fds` where it tries to do something equivalent to "small string optimization" to potentially avoid a malloc. core_sys_select() calls do_select() which has another potentially large stack allocation, `table`. Both of these values depend on FRONTEND_STACK_ALLOC. Mix those two large allocation with register spills which are exacerbated by various configs and compiler versions and we can just barely exceed the 1024B limit. Rather than keep trying to find the right value of MAX_STACK_ALLOC or FRONTEND_STACK_ALLOC, mark do_select() as noinline_for_stack for 32b targets. The intent of FRONTEND_STACK_ALLOC is to help potentially avoid a dynamic memory allocation. In that spirit, restore the previous threshold but separate the stack frames for 32b targets. Link: https://lore.kernel.org/lkml/20221006222124.aabaemy7ofop7ccz@google.com/ Fixes: ad312f9 ("fs/select: avoid clang stack usage warning") Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
- Loading branch information